Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server, sessionctx: improved mysql compatibility with support for init_connect (#23713) #26072

Merged
merged 4 commits into from
Aug 12, 2021
Merged

server, sessionctx: improved mysql compatibility with support for init_connect (#23713) #26072

merged 4 commits into from
Aug 12, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 8, 2021 •
edited
Loading

cherry-pick #23713 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/26072

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/26072:release-5.0-9c75cfa4e2bb

What problem does this PR solve?

Issue Number: close #18894

Problem Summary:

MySQL supports the ability to execute a set of statements on first connection. This PR adds the same feature to TiDB.

It can be useful for some applications, since SQL modes can be set, user variables, etc. It is also used extensively in the mysql-test testsuite.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test: server integration tests.

Side effects

  • Performance regression
    • Regrettably checking if initconnect returned an error is in the query-serving path. This was required to return the client an error.

Release note

  • TiDB now supports the mysql system variable init_connect and associated functionality.

@morgo @ti-srebot
cherry pick pingcap#23713 to release-5.0
31402ae 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.0-cherry-pick labels Jul 8, 2021
@ti-srebot ti-srebot mentioned this pull request Jul 8, 2021
Merged
@ti-srebot ti-srebot requested review from AilinKid and xhebox July 8, 2021 21:50
@ti-srebot ti-srebot added this to the v5.0.3 milestone Jul 8, 2021
@ti-srebot
Copy link
Contributor Author

@morgo you're already a collaborator in bot's repo.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 9, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 9, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 11, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 12, 2021
@AilinKid
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: df04318

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 12, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit da52bcc into pingcap:release-5.0 Aug 12, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.3, v5.0.4 Sep 10, 2021
This was referenced Sep 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@xhebox xhebox xhebox approved these changes

Assignees

@morgo morgo

Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Milestone
v5.0.4
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @ti-chi-bot @AilinKid @xhebox @morgo @zhouqiang-cl